Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Letting flags be changed from outside #223

Merged
knative-prow-robot merged 2 commits into from
Dec 4, 2019
Merged

Letting flags be changed from outside #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9376043
Adding Goland to gitignore
cardil Nov 14, 2019
15b182e
Letting flags be changed from outside
cardil Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Temporary Build Files
build/_output
build/_test
# Goland
.idea
Copy link
Member

@matzew matzew Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure on getting this in.... I guess... shouldn't those be on your own global .gitignore ?

Copy link
Contributor Author

@cardil cardil Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean by using git config --global core.excludesfile option?

I think not many people actually use that. I didn't hear of that option, nor any of developers in my office (I know that's not representative 😉)

On top that it is easier for newcomers, so that repo declares those ignores.


Copy link
Member

@matzew matzew Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that ?

Copy link

@houshengbo houshengbo Nov 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say not change this .gitignore by far.
The script under /hack/update-deps.sh is supposed to update the dependencies, and remove the useless files, including OWNERS. However, some packages may keep them, based on the configuration in Gopkg.toml. Let's keep the dependencies(with all the files) based on what is generated by /hack/update-deps.sh.

Copy link
Contributor Author

@cardil cardil Nov 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing those.

# Created by https://www.gitignore.io/api/go,vim,emacs,visualstudiocode
### Emacs ###
# -*- mode: gitignore; -*-
Expand Down
6 changes: 3 additions & 3 deletions hack/update-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ set -o pipefail

source $(dirname $0)/../vendor/knative.dev/test-infra/scripts/library.sh

cd ${REPO_ROOT_DIR}
cd "${REPO_ROOT_DIR}"

# Ensure we have everything we need under vendor/
dep ensure

rm -rf $(find vendor/ -name 'OWNERS')
rm -rf $(find vendor/ -name '*_test.go')
find vendor/ -name 'OWNERS' -delete
find vendor/ -name '*_test.go' -delete

update_licenses third_party/VENDOR-LICENSE "./cmd/*"

Expand Down
16 changes: 13 additions & 3 deletions test/e2e_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,19 @@ limitations under the License.

package test

const (
import "os"

var (
// ServingOperatorNamespace is the default namespace for serving operator e2e tests
ServingOperatorNamespace = "operator-tests"
ServingOperatorNamespace = getenv("TEST_NAMESPACE", "operator-tests")
// ServingOperatorName is the default operator name for serving operator e2e tests
ServingOperatorName = "knative-serving"
ServingOperatorName = getenv("TEST_RESOURCE", "knative-serving")
)

func getenv(name, defaultValue string) string {
value, set := os.LookupEnv(name)
if !set {
value = defaultValue
}
return value
Copy link
Member

@matzew matzew Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}