[Ready] Replacing Competition with Cooperation to Achieve Scalable Lock-Free … #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@NikitaKomp, explain, please, why it is needed to change license of some part of the library? |
eugenyk
suggested changes
Feb 5, 2019
test/stress/queue/push.cpp
Outdated
| if ( !m_Queue.push( nItem )) { | ||
| ++m_nPushError; | ||
| } | ||
| //EXPECT_TRUE(false) << "nItem = " << nItem; |
Contributor
There was a problem hiding this comment.
Remove all commented source code
| /* | ||
| This file is a part of libcds - Concurrent Data Structures library | ||
| (C) Copyright Maxim Khizhinsky (libcds.dev@gmail.com) 2006-2017 |
| for ( size_t i = 0; i < nSize; ++i ) | ||
| { | ||
| q.push( arr[i] ); | ||
| ASSERT_CONTAINER_SIZE( q, i+1); |
Contributor
There was a problem hiding this comment.
Random indent, use library source code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…FIFO Queues (Компанищенко, Зырянов)