Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

fix: Use vanilla podtato-head images for quickstart #214

Merged
thisthat merged 1 commit into from
Dec 6, 2021
Merged

fix: Use vanilla podtato-head images for quickstart #214

thisthat merged 1 commit into from
Dec 6, 2021

Conversation

@christian-kreuzberger-dtx
Copy link
Member

@christian-kreuzberger-dtx christian-kreuzberger-dtx commented Dec 6, 2021 •
edited
Loading

This PR

changes the quickstart guide using podtato-head as follows

  • Upgrade to prometheus-service 0.7.1
  • Fix a typo in the source field when simulating an alert using prometheus
  • Use vanilla (original) podtato-head images
  • Change jmeter config in order to decrease the time needed for the performance test executed using JMeter
  • Change SLI/SLO defnition to fit the vanilla (original) podtato-head-images

Fixes #213

Proof

v0.1.1

image

image

v0.1.2 (slow version)

image

image

simulated remediation

image

@christian-kreuzberger-dtx
fix: Use vanilla podtato-head images for quickstart
99ac163 
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@christian-kreuzberger-dtx christian-kreuzberger-dtx marked this pull request as ready for review December 6, 2021 12:36
@jetzlstorfer
Copy link
Member

jetzlstorfer commented Dec 6, 2021

Thanks @christian-kreuzberger-dtx for providing this PR 👍🏼
I'd favor having this merged into the repo, but I'll leave the decision to more active maintainers :)

thisthat
thisthat approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thisthat thisthat merged commit 4dcf77e into master Dec 6, 2021
@thisthat thisthat deleted the patch/213/podtatohead branch December 6, 2021 13:18
@christian-kreuzberger-dtx christian-kreuzberger-dtx mentioned this pull request Dec 17, 2021
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AloisReitbauer AloisReitbauer Awaiting requested review from AloisReitbauer AloisReitbauer is a code owner

1 more reviewer

@thisthat thisthat thisthat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use "vanilla" podtato-head images for quickstart

4 participants

@christian-kreuzberger-dtx @jetzlstorfer @thisthat