fix: apply lastReceived field format changes in custom feeds#6187
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: apply lastReceived field format changes in custom feeds#6187DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5236
Problem
In custom (backend-persisted) feeds, changing the format of the
lastReceivedfield via the column header dropdown had no visible effect. The format change appeared to succeed silently - no error was shown - but the column continued rendering timestamps in the previous format.Root Cause
Custom feeds (non-static presets) use a backend API to persist column configuration, including
columnTimeFormats. This is managed by theusePresetColumnStatehook, which reads and writes format settings viausePresetColumnConfig. TheAlertTableServerSidecomponent correctly passes the syncedcolumnTimeFormatsto the table viatable.options.meta.However, the cell renderers in
useAlertTableCols(insidealert-table-utils.tsx) readcolumnTimeFormatsexclusively from React local storage viauseLocalStorage-- a closure-captured value that is never updated when the backend state changes. This caused the visual display to remain stale even after the backend was successfully updated.Fix
useAlertTableCols(thelastReceivedaccessor and the generic date column renderer infilteredAndGeneratedCols) to prefercontext.table.options.meta?.columnTimeFormatsover the local storage fallback. This ensures custom feeds render using the authoritative, backend-synced format.TableMetainterface declaration inkeep-ui/types/react-table.d.tsto includecolumnTimeFormatsandsetColumnTimeFormats, providing proper TypeScript typing for the table metadata already set byAlertTableServerSide.Static presets and the deprecated
AlertTablecomponent are unaffected -- they do not setmeta.columnTimeFormats, so the local storage fallback continues to apply.Files Changed
keep-ui/widgets/alerts-table/lib/alert-table-utils.tsx-- readcolumnTimeFormatsfrom table meta when availablekeep-ui/types/react-table.d.ts-- extendTableMetawithcolumnTimeFormatsandsetColumnTimeFormats