fix: preserve original timestamps on workflow revisions#6186
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: preserve original timestamps on workflow revisions#6186DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5328
Problem
In the workflow Versions panel, every revision was displaying the same timestamp — the time of the most-recent save. Older revisions had their
updated_attimestamp silently overwritten each time a new revision was created.Root Cause
WorkflowVersion.updated_atwas defined withonupdate=func.now()in the SQLAlchemy model:When saving a new revision, the code first runs:
This UPDATE statement touched every existing revision row, causing the database to fire the
ON UPDATE CURRENT_TIMESTAMPtrigger on each one. As a result, all prior revisions got theirupdated_atoverwritten to the current time — making every revision appear to have been created at the same moment.Fix
Model (
keep/api/models/db/workflow.py): Removedonupdate=func.now()fromWorkflowVersion.updated_at. The column still gets aserver_defaultso it is populated on INSERT, but subsequent UPDATEs no longer mutate the timestamp.Migration (
2025-07-01-00-00_fix_workflowversion_updated_at.py): Alters the column definition in-place (usingbatch_alter_tablefor SQLite compatibility) to drop theON UPDATEbehaviour while keeping existing data intact.Testing
Checklist