Leverage caffeinate -w instead of killall#38
Open
saladd-bu wants to merge 1 commit intokandji-inc:mainfrom
Open
Leverage caffeinate -w instead of killall#38saladd-bu wants to merge 1 commit intokandji-inc:mainfrom
saladd-bu wants to merge 1 commit intokandji-inc:mainfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to update the InstallLargePKG.sh approach to a more precise caffeinate usage.
Currently, the script uses
killall caffeinate, which may inadvertently kill instances of caffeinate present on the machine through other means.This updated approach uses caffeinate's
-wparameter in combination with shell built-in variable$$to provide caffeinate with the script's shell instance PID. Once the script completes (or otherwise exits/terminates), the instance of caffeinate created during script execution will tear itself down while leaving other instances running (if present).