Skip to content

test: add CDC scenarios to test value generation#689

Merged
kalbasit merged 1 commit intomainfrom
02-01-test_add_cdc_scenarios_to_test_value_generation
Feb 2, 2026
Merged

test: add CDC scenarios to test value generation#689
kalbasit merged 1 commit intomainfrom
02-01-test_add_cdc_scenarios_to_test_value_generation

Conversation

@kalbasit
Copy link
Owner

@kalbasit kalbasit commented Feb 2, 2026

Updates dev-scripts/generate-test-values.sh to include test scenarios for Content-Defined Chunking (CDC).

This adds:

  • Single instance S3 + SQLite + CDC
  • HA S3 + PostgreSQL + Redis + CDC

These scenarios allow for testing the CDC functionality in both single-node and high-availability configurations, ensuring that chunking and deduplication work as expected.

Updates dev-scripts/generate-test-values.sh to include test scenarios for Content-Defined Chunking (CDC).

This adds:
- Single instance S3 + SQLite + CDC
- HA S3 + PostgreSQL + Redis + CDC

These scenarios allow for testing the CDC functionality in both single-node and high-availability configurations, ensuring that chunking and deduplication work as expected.
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 2, 2026
@dosubot
Copy link

dosubot bot commented Feb 2, 2026

Related Documentation

No published documentation to review for changes on this repository.

Write your first living document

How did I do? Any feedback?  Join Discord

@dosubot dosubot bot added the enhancement New feature or request label Feb 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kalbasit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the test infrastructure by integrating new test scenarios specifically designed for Content-Defined Chunking (CDC). It introduces configurations for both single-instance and high-availability deployments, utilizing S3 for storage and PostgreSQL as the database, with Redis also enabled for the HA setup. These additions are crucial for thoroughly validating CDC functionality across diverse operational environments and ensuring its robustness.

Highlights

  • New CDC Test Scenarios: Introduced two new test scenarios for Content-Defined Chunking (CDC): a single instance setup with S3 storage and PostgreSQL, and a high-availability setup with S3 storage, PostgreSQL, and Redis.
  • Script Updates: The dev-scripts/generate-test-values.sh script has been updated to generate, install, and manage these new CDC-enabled configurations, including modifications to the quick install script, namespace cleanup, and testing matrix documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Owner Author

kalbasit commented Feb 2, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new test scenarios for Content-Defined Chunking (CDC): a single-node setup and a high-availability setup. The changes correctly update the test value generation script, along with the corresponding installation, cleanup, and documentation files.

Please note that while the pull request description mentions a 'Single instance S3 + SQLite + CDC' scenario, the implementation adds a 'Single instance S3 + PostgreSQL + CDC' scenario. This is consistent with the generated file names and content, so it's likely just a typo in the description.

I've kept the comment suggesting a refactoring of the generate-test-values.sh script to improve its long-term maintainability by reducing code duplication, as it does not contradict any provided rules. Overall, the changes are a good addition to the test suite.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.16%. Comparing base (297726b) to head (896bfe2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files           2        2           
  Lines         456      456           
=======================================
  Hits          361      361           
  Misses         83       83           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalbasit kalbasit merged commit 37a44db into main Feb 2, 2026
13 checks passed
@kalbasit kalbasit deleted the 02-01-test_add_cdc_scenarios_to_test_value_generation branch February 2, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant