Organize files

[asamuzaK]

• Created utils/camelize.js

• Put generated files under generated/

• Switched to const and let

• Updated code style rules through prettier

• Added @domenic/eslint-config rules

• Updated CSSStyleDeclaration class to match the latest spec
  see https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface

  • cssText getter:
    • Returns empty string if computed flag is set
  • cssText setter:
    removeProperty():
    setProperty():
    • Throws if readonly flag is set
  • parentRule() getter:
    • Returns parent CSSRule if associated

  Note that the above flags and methods needs additional fixes on jsdom side

  • item():
    • Throws if no argument given
      see also https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/item
  • -webkit-* prefixed properties:
    • Adds Camel Cased and Pascal Cased properties, e.g.) style['-webkit-foo'], style.webkitFoo and style.WebkitFoo are added

• Rewritten properties/*.js files

  • Unified each file to export three functions: parser (exports.parse), validator (exports.isValid), and descriptor (exports.definition)
  • Removed deprecated azimuth and some deprecated webkit prefixed properties
    see also https://developer.mozilla.org/en-US/docs/Web/CSS/WebKit_Extensions

• Renamed test files -> *.test.js and added tests

Fixes #200, Fixes #201, Fixes #202, Fixes #203, Fixes #204, Fixes #205,
Fixes #206, Fixes #207, Fixes #70, Fixes #124, Fixes #129,
Fix jsdom issues: jsdom/jsdom#3878, jsdom/jsdom#3833
Also we can close #120, I think.

[asamuzaK]

@domenic
Almost ready.

Do you think we still need webkitXXX.js files under ./properties/?
Is it okay to remove them?

[domenic]

I'm not sure I understand enough project architecture to know exactly what those files are currently doing.

We need to support this part of the spec: https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface:~:text=fontSize%20IDL%20attribute.-,For%20each%20CSS%20property%20property,exceptions%20thrown%20must%20be%20re%2Dthrown.,-For%20example%2C%20if . Do those files help with that?

[asamuzaK]

Back to draft.
I'll do one more work to fix #129

[asamuzaK]

PR ready again.

[asamuzaK]

Sorry, found a bug.

[asamuzaK]

It ended up being a fairly large fix, but shouldn't be a breaking change.
Please review.

[domenic]

I finally tried to make some time to review this. It's... too large to really review. But I will sign off on it, and merge it and do a release this weekend.

The only things I would like to request is more details on "Updated CSSStyleDeclaration class to match the latest spec" and "Rewritten properties/*.js files". That would help write the changelog better.

---

Also worth noting, but not a blocking issue: the test coverage here is amazing. But I am sad it is not in web platform tests format, which would make it easier to validate that we are matching browser behavior.

I don't know what a good solution to this is since I know having quick to run unit tests in this project is nicer than having to do a full integration test with jsdom.

Some possible ideas:

• Be sure we have jsdom web platform tests for all web platform issues opened by real users. E.g. #70, #124, #129 (you already added tests), jsdom/jsdom#3878, jsdom/jsdom#3833.

• Use AI to port some tests, e.g. CSSStyleDeclaration.test.js and properties.test.js. This is kind of annoying to keep in sync.

• Port the tests to web platform tests format, but write them in a way that they can be run with a small wrapper like https://github.com/jsdom/whatwg-url/blob/414f17a3459b0872baee7a2b77e23953b8a5ccd9/test/web-platform.js#L159-L188 .

If you are interested, feel free to open a tracking issue for these ideas. Or if you prefer just using the current workflow, that is fine too, as you are the one doing all of the work.

[asamuzaK]

The only things I would like to request is more details on "Updated CSSStyleDeclaration class to match the latest spec" and "Rewritten properties/*.js files".

I think I can have them ready on Saturday, or at the latest by Sunday noon (JST), is that okay?

Port the tests to web platform tests format, but write them in a way that they can be run with a small wrapper like https://github.com/jsdom/whatwg-url/blob/414f17a3459b0872baee7a2b77e23953b8a5ccd9/test/web-platform.js#L159-L188 .

Interesting.
I'll take a look at it later.

[asamuzaK]

@domenic
Added details to the PR comment.
Please feel free to let me know if you have any additional requests.