Skip to content

Conversation

@yorkie
Copy link
Collaborator

@yorkie yorkie commented Jul 2, 2025

No description provided.

@yorkie yorkie requested a review from Copilot July 3, 2025 05:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the renderer’s context storage and debugging infrastructure to address stencil buffer issues and unify host/app GL context handling, while also exposing new runtime statistics via the inspector.

  • Introduce new ContextGLHost/ContextGLApp classes and rename storage methods (on*) to replace legacy context storage.
  • Add iterateContentRenderers API and extend inspector with a /json/statistics endpoint.
  • Add framebuffer‐attachment helpers, update debug output (including stencil state), and adjust project build/configuration files.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/runtime/inspector.hpp Declare new getStatistics method
src/runtime/inspector.cpp Implement statistics route and JSON output
src/runtime/embedder.cpp Fix perfFs field access
src/renderer/renderer.hpp Rename OpenGL context type, add iterateContentRenderers
src/renderer/renderer.cpp Update context usage, implement iterateContentRenderers
src/renderer/render_api_opengles.cpp Rename context methods, add stencil state debug output
src/renderer/gles/context_storage.hpp Refactor storage API, rename classes and methods
src/renderer/gles/context_storage.cpp Update record/restore implementations
src/renderer/gles/context_host.hpp Add host context class
src/renderer/gles/context_host.cpp Implement host context record/restore and framebuffer tracking
src/renderer/gles/context_app.hpp Add app context class
src/renderer/gles/context_app.cpp Implement app context lifecycle callbacks
src/renderer/gles/framebuffer_attachment.hpp New framebuffer-attachment helper
src/renderer/gles/framebuffer.hpp New GLFramebuffer wrapper
src/renderer/gles/framebuffer.cpp Implement wrapper methods
src/renderer/gles/common.hpp Add texture-target string and include updates
src/renderer/gles/common.cpp Implement glTextureTargetToString, extend internal-format strings
src/renderer/content_renderer.hpp Update context type, add frame timing fields
src/renderer/content_renderer.cpp Refactor backup context, frame execution logic
src/examples/desktop_opengl.cpp Update OpenGL version/context hints and flags
src/common/debug.hpp Add performance counter macro definitions
src/common/classes.hpp Forward-declare TrInspector
src/client/builtin_scene/texture_altas.cpp Switch to texStorage3D, update atlas initialization
makefile Remove unused release-flag override
build/configure.sh Enable CMAKE_EXPORT_COMPILE_COMMANDS
.vscode/c_cpp_properties.json Add Android IntelliSense configuration

@yorkie yorkie merged commit bb36f33 into main Jul 3, 2025
2 checks passed
@yorkie yorkie deleted the refactor/renderer branch July 3, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants