Fix RenderBackgroundSystem::drawImage background-repeat logic for negative repeat regions #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background-repeat implementation was incorrectly handling image tiles in negative directions when
background-origincreated an offset from the border-box. This caused visible gaps in repeated background images.Problem
When
background-repeatwas set torepeat-xorrepeat-yandbackground-originwas set tocontent-boxorpadding-box, the tiling logic would only generate tiles from the origin position outward, leaving regions before the origin uncovered.For example:
x=0tox=300x=100tox=300(100px offset due to border + padding)background-origin: content-boxandrepeat-x, tiles would only appear fromx=100onwardsx=0tox=100would remain uncovered, despite being within the paintable areaRoot Cause
The
drawImagefunction was using thepositioningArea(calculated frombackground-origin) for both:background-cliparea)This violated the CSS specification where
background-originshould only affect the initial position offset, not the extent of repeated tiles.Solution
drawImagefunction accepting separate positioning and repeatable areasrepeatableAreabounds instead ofpositioningAreaboundsbackground-cliparea as repeatable area andbackground-originarea as positioning arearepeat,repeat-x,repeat-y) use the correct repeatable boundsTest Results
The fix ensures background images properly tile across the entire visible area while respecting the positioning offset specified by
background-origin.Fixes #279.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
registry.npmmirror.comnpm ci(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.