Skip to content

Conversation

@AnorBertran
Copy link
Contributor

Now you can specify "Title" match in "Group" section:

<Group>
    <Title>Some window title</Title>
    <!-- ... -->
</Group>

@AnorBertran
Copy link
Contributor Author

My bad, duplicates #519

@joewing
Copy link
Owner

joewing commented Jun 13, 2022

It appears that I'm fighting a losing battle with this one 😄
Because the title can change and may not even be set when the window is mapped, I tend to think it's a bad idea to use the window title for matching. On the other hand, this particular thing has been implemented twice before (PRs #265 and #519) and it's been requested at least three times now (issues #234, #416 and now #575).
So I'm thinking I may just let this go through (I might just update the documentation at some point to reflect the fact that this match only runs when the window initially appears).
I guess the question is which PR... The three PRs are very similar, but all use a different name for the tag. Though I have to admit, I like "Title" the best!

@AnorBertran
Copy link
Contributor Author

AnorBertran commented Jun 14, 2022

It appears that I'm fighting a losing battle with this one 😄
Because the title can change and may not even be set when the window is mapped, I tend to think it's a bad idea to use the window title for matching. On the other hand, this particular thing has been implemented twice before (PRs #265 and #519) and it's been requested at least three times now (issues #234, #416 and now #575).
So I'm thinking I may just let this go through (I might just update the documentation at some point to reflect the fact that this match only runs when the window initially appears).
I guess the question is which PR... The three PRs are very similar, but all use a different name for the tag. Though I have to admit, I like "Title" the best!

What about title changes monitoring and remap if title match. Probably, more wasteful than useful..

@joewing joewing merged commit d8d4f54 into joewing:master Jun 14, 2022
@joewing
Copy link
Owner

joewing commented Jun 14, 2022

Thanks!
I went ahead and merged this one. Probably fine as is without making it more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants