JWM crashes when the "Mouse" tag does not have the "context" attribute

[sleeptightAnsiC]

Hello,

I've found out that JWM will crash (segfault), if I use Mouse tag without context attribute, anywhere inside of my $HOME/.jwmrc config.

reduced testcase:

<?xml version="1.0"?>
<JWM>
    <Mouse
        mask="4"
        button="1"
    >move</Mouse>
</JWM>

repro: save the testcase from above to $HOME/.jwmrc and exec jwm -p :
(trying to Restart via jwm -restart or start with startx will also result in crash)

$ jwm -p
Segmentation fault         (core dumped) jwm -p

callstack:

#0  __strcmp_avx2 () at ../sysdeps/x86_64/multiarch/strcmp-avx2.S:283
#1  0x0000555555574896 in FindValue (mapping=mapping@entry=0x555555592840 <MC_MAP>, count=count@entry=7, key=key@entry=0x0) at misc.c:251
#2  0x0000555555579e4a in ParseMouse (tp=0x5555555b55f0) at parse.c:993
#3  Parse (start=start@entry=0x5555555b56d0, depth=depth@entry=1) at parse.c:380
#4  0x000055555557b888 in ParseFile (fileName=<optimized out>, depth=1) at parse.c:324
#5  ParseConfig (fileName=<optimized out>) at parse.c:291
#6  0x000055555555d2ad in main (argc=2, argv=0x7fffffffdb48) at main.c:153

locals and args in frame: #1 0x0000555555574896 in FindValue(...) at misc.c:251 :

(gdb) info locals
x = 3
rc = <optimized out>
left = 0
right = 6
(gdb) info args
mapping = 0x555555592840 <MC_MAP>
count = 7
key = 0x0

my environment:

$ jwm -v
JWM v2.4.6 by Joe Wingbermuehle
compiled options: confirm icons jpeg nls pango png shape svg xbm xft xinerama xpm xrender 
system configuration: /home/korn/.local/jwm/etc/system.jwmrc
$ uname -a
Linux MAL200424 6.16.8-arch3-1 #1 SMP PREEMPT_DYNAMIC Mon, 22 Sep 2025 22:08:35 +0000 x86_64 GNU/Linux
$ cc --version
cc (GCC) 15.2.1 20250813
$ ldd --version
ldd (GNU libc) 2.42

I installed JWM from latest source release from https://github.com/joewing/jwm/releases/download/v2.4.6/jwm-2.4.6.tar.xz
There are NO custom patches applied to it. I haven't used any ./configure options other than --prefix=$HOME/.local/jwm

[sleeptightAnsiC]

Also, just for comparison, if I remove everything else from Mouse tag and keep the context attribute alone, it will NOT crash. It just prints warning and keeps going in this case:

$ cat $HOME/.jwmrc 
<?xml version="1.0"?>
<JWM>
    <Mouse
        context="root"
    >move</Mouse>
</JWM>

$ jwm -p
JWM: warning: $HOME/.jwmrc[3]: no value specified

[joewing]

Thanks for reporting this. I'll try to get a fix out soon (it should be an easy fix).

[sleeptightAnsiC]

Thanks @joewing ,

I just retested on 032455c and the crash is fixed. It now prints the warning just like expected:

$ src/jwm -p -f testcase.xml 
JWM: warning: testcase.xml[3]: invalid Mouse context: "(null)"

Feel free to close this Issue. I'm keeping it open in case you want to do something related to it.

[sleeptightAnsiC]

Also small heads up (and note for future me): I had some issues with gettext when building from git:

$ git clone https://github.com/joewing/jwm.git
$ cd jwm
$ ./autogen.sh
[...]
configure.ac:440: warning: macro 'AM_ICONV' not found in library
configure.ac:441: warning: macro 'AM_GNU_GETTEXT' not found in library
configure.ac:442: warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library
automake: error: no 'Makefile.am' found for any configure output
configure.ac:440: warning: macro 'AM_ICONV' not found in library
configure.ac:441: warning: macro 'AM_GNU_GETTEXT' not found in library
configure.ac:442: warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library
configure.ac: warning: AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION is used, but not AM_GNU_GETTEXT 
configure.ac:480: error: possibly undefined macro: AM_ICONV If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation.
configure.ac:481: error: possibly undefined macro: AM_GNU_GETTEXT
configure.ac:482: error: possibly undefined macro: AM_GNU_GETTEXT_VERSION
autoreconf: error: /usr/bin/autoconf failed with exit status: 1

I'm not familiar with Autotools, so this might be a problem with my setup, but I was able to quickly fix it with:

export ACLOCAL_PATH=/usr/share/gettext/m4

It would still fail to build translations from ./po/* due to some missing Makefile rules, but since it was able to compile the executable just fine, I didn't mind it anymore.