Rebased my fork to jenkins' instead of doug#1
Rebased my fork to jenkins' instead of doug#1d6y merged 20 commits intojenkinsci:masterfrom longlho:master
Conversation
This reverts commit a089a3d.
…he root cause is reported
…ofile is created instead of login/logout due to thread-safe issue
…ataBoundConstructor annotation to be compatible with new jenkins, added 1 unit test, more to come
|
Thank you: that's made it a lot easier to deal with. Locally merging and testing.... |
|
I'm unclear on how to progress the upload() code. Can you let me know what the intention is or what the scenario is? See my comment https://github.com/longlho/hudson-s3/commit/016c2d9c62ae94ceae801beb87741f9ede284248#commitcomment-646429 Cheers |
|
Yup sorry for the confusion. I've added a comment right under yours. Thanks, LH |
…tor since it's URI, not file path
|
I've put in the fix for the IndexOutOfBound issue. I only did split once since the 1st argument only needs bucketname and the object path can be the rest. Thus, there's no need to split more than once. Let me know what you think. Thanks a lot for your feedbacks!! |
|
Thanks for the fix - I've merged this after extracting the bucket/file name logic into a separate class to make it easier to unit test. I've tested the s3.hpi with some small files, but I'd like to test with some much larger files, and then I'll go figure out how to publish this to Jenkins properly and write the wiki page for this plugin (long overdue). |
INFRA-3043 Approved-by: Andrew Newell <andrew.newell@inin.com> Approved-by: Lew Gordon <lew.gordon@inin.com>
2 participants
Rebased my fork to jenkins' instead of doug since it's newer