Fix code at head, pytype errors, and small Event refactoring#50
Open
jeremywhelchel wants to merge 10 commits intojeffthibault:mainfrom
Open
Fix code at head, pytype errors, and small Event refactoring#50jeremywhelchel wants to merge 10 commits intojeffthibault:mainfrom
jeremywhelchel wants to merge 10 commits intojeffthibault:mainfrom
Conversation
Contributor
|
Ended up fixing this as well here: callebtc#5. The This is a great PR. LGTM. |
This was referenced Feb 7, 2023
Author
|
Thanks @callebtc @jeffthibault WDYT? could be three separate prs:
Looking for feedback before doing anything else here FWIW, here is the relevant pytype failures wrt the Event() breakage: I'm a big fan of using pytype to catch these breakages. |
|
Bumping this one, would love to see it get merged. |
|
been 2 months since a merge. guessing @jeffthibault is asleep. thinking either (a) fork or (b) ask jeff to promote a couple maintainers... clearly no lack of people want to help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code was broken at head after yesterday's Event dataclass refactoring.
pytype would have caught this error. So I fixed all the outstanding pytype errors in anticipation of (hopefully) adding some automated pytype checking to the repo.