Issue with npub key signing for DM messages#101
Open
realJogicodes wants to merge 55 commits intojeffthibault:mainfrom
Open
Issue with npub key signing for DM messages#101realJogicodes wants to merge 55 commits intojeffthibault:mainfrom
realJogicodes wants to merge 55 commits intojeffthibault:mainfrom
Conversation
Connection_state
Fix/nostr_close
…nto jeffthibault-main
fix: Events initialization
Feat/count_events
threads are daemon mode
Avoid failure if the subscription_id referenced is no longer present in subscriptions
Update relay.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the current code of this fork, signing DMs does not work for me.
This code:
Causes this:
To investigate a little, I printed
public_key_hexabove line 66, in nostr/key.py and it prints asnpub.... The first two characters,npare not hex characters, so the stringpublic_key_hexis not hex compatible.What I suspect would fix this is that the npub needs to be converted into the hex pubkey before line 66 is happening but that's a little above my skill level to implement