Skip to content

Update proptest2.h.R#343

Open
atpinto wants to merge 1 commit intojamovi:masterfrom
atpinto:patch-1
Open

Update proptest2.h.R#343
atpinto wants to merge 1 commit intojamovi:masterfrom
atpinto:patch-1

Conversation

@atpinto
Copy link

@atpinto atpinto commented Mar 31, 2022

Currently, when we enter data in aggregate format (the option "Values are counts"), jamovi still expects an ordinal or nominal variable. However, strictly speaking, the counts are numeric and if we change the "Measure type" to continuous, the variable with the counts is no longer accepted in the variable box for the Binomial Test.

Notice that in contrast to the above, in the McNemar's test command, the type of variable expected in the "counts" field, is correctly specified as "continuous"!

I suggest adding to lines 34/35 other types of variables

permitted=list(
"factor", "numeric", "continuous"))

 Currently, when we enter data in aggregate format (the option "Values are counts"), jamovi still expects an ordinal or nominal variable.  However, strictly speaking, the counts are numeric and if we change the "Measure type" to continuous, the variable with the counts is no longer accepted in the variable box for the Binomial Test.

Notice that in contrast to the above, in the McNemar's test command, the type of variable expected in the "counts" field, is correctly specified as "continuous"!

I suggest adding to lines 34/35 other types of variables

permitted=list(
                    "factor", "numeric", "continuous"))
@jonathon-love
Copy link
Member

this isn't a bad suggestion, however i think more work is needed to ensure that jamovi behaves reasonably when continuous variables are assigned and 'Values are counts' isn't checked (i.e. at the moment i think it will throw a cryptic error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments