Open
Conversation
Currently, when we enter data in aggregate format (the option "Values are counts"), jamovi still expects an ordinal or nominal variable. However, strictly speaking, the counts are numeric and if we change the "Measure type" to continuous, the variable with the counts is no longer accepted in the variable box for the Binomial Test.
Notice that in contrast to the above, in the McNemar's test command, the type of variable expected in the "counts" field, is correctly specified as "continuous"!
I suggest adding to lines 34/35 other types of variables
permitted=list(
"factor", "numeric", "continuous"))
Member
|
this isn't a bad suggestion, however i think more work is needed to ensure that jamovi behaves reasonably when continuous variables are assigned and 'Values are counts' isn't checked (i.e. at the moment i think it will throw a cryptic error). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when we enter data in aggregate format (the option "Values are counts"), jamovi still expects an ordinal or nominal variable. However, strictly speaking, the counts are numeric and if we change the "Measure type" to continuous, the variable with the counts is no longer accepted in the variable box for the Binomial Test.
Notice that in contrast to the above, in the McNemar's test command, the type of variable expected in the "counts" field, is correctly specified as "continuous"!
I suggest adding to lines 34/35 other types of variables
permitted=list(
"factor", "numeric", "continuous"))