Fix fallback config confusion #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sslmode was blank then some of the fallback config was not being set properly. This was because blank is treated as "prefer" by pgx (which follows libpq's behavior). But tern parsing parsing the config in several places and then trying to fix the fallback config. It missed the default "prefer" case. The solution was to avoid the multiple parsing and fallback config logic entirely. Instead, we set the PG* environment variables from the CLI options and config file before parsing the conn string. #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sslmode was blank then some of the fallback config was not being set properly. This was because blank is treated as "prefer" by pgx (which follows libpq's behavior). But tern parsing parsing the config in several places and then trying to fix the fallback config. It missed the default "prefer" case.
The solution was to avoid the multiple parsing and fallback config logic entirely. Instead, we set the PG* environment variables from the CLI options and config file before parsing the conn string.
#38