-
Notifications
You must be signed in to change notification settings - Fork 236
Repeatable random object on the same seed #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170 changes: 170 additions & 0 deletions
170
easy-random-core/src/test/java/org/jeasy/random/RepeatableRandomTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,170 @@ | ||
| /* | ||
| * The MIT License | ||
| * | ||
| * Copyright (c) 2020, Mahmoud Ben Hassine (mahmoud.benhassine@icloud.com) | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| */ | ||
| package org.jeasy.random; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Objects; | ||
| import java.util.concurrent.ThreadLocalRandom; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class RepeatableRandomTest { | ||
|
|
||
| @Test | ||
| public void validateEqualsAndHashCodeSameRandomInstancePoolSize1() { | ||
| for (int i = 0; i < 3; i++) { | ||
| validateEqualsAndHashCodeSameRandomInstanceImpl(1); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void validateEqualsAndHashCodeSameRandomInstancePoolSize3() { | ||
| for (int i = 0; i < 3; i++) { | ||
| validateEqualsAndHashCodeSameRandomInstanceImpl(3); | ||
| } | ||
| } | ||
|
|
||
| private void validateEqualsAndHashCodeSameRandomInstanceImpl(int poolSize) { | ||
| long seed = ThreadLocalRandom.current().nextLong(); | ||
|
|
||
| Object instance1 = randomInstance(Pojo.class, seed, poolSize); | ||
| // same seed - hence same object expected | ||
| Object instance2 = randomInstance(Pojo.class, seed, poolSize); | ||
|
|
||
| assertThat(instance1) | ||
| .isEqualTo(instance2); | ||
| assertThat(instance1.hashCode()) | ||
| .isEqualTo(instance2.hashCode()); | ||
| } | ||
|
|
||
| private Object randomInstance(Class<?> type, long seed, int poolSize) { | ||
| EasyRandom easyRandom = new EasyRandom(new EasyRandomParameters() | ||
| .objectPoolSize(poolSize) | ||
| .seed(seed) | ||
| .stringLengthRange(3, 5) | ||
| .collectionSizeRange(3, 4)); | ||
| return easyRandom.nextObject(type); | ||
| } | ||
|
|
||
| public static class Pojo { | ||
|
|
||
| private String id; | ||
|
|
||
| private List<PojoA> a; | ||
|
|
||
| private List<PojoB> b; | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| Pojo that = (Pojo) o; | ||
| return id.equals(that.id) | ||
| && a.equals(that.a) | ||
| && b.equals(that.b); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(id, a, b); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Pojo{" + | ||
| "id='" + id + '\'' + | ||
| ", a=" + a + | ||
| ", b=" + b + | ||
| '}'; | ||
| } | ||
| } | ||
|
|
||
| public static class PojoA { | ||
|
|
||
| private String s; | ||
|
|
||
| // equals/hashCode/toString by id to avoid possible stack overflow | ||
| private Pojo root; | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| PojoA that = (PojoA) o; | ||
| return s.equals(that.s) | ||
| && root.id.equals(that.root.id); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(s, root.id); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "PojoA{" + | ||
| "s='" + s + '\'' + | ||
| ", root.id=" + root.id + | ||
| '}'; | ||
| } | ||
| } | ||
|
|
||
| public static class PojoB { | ||
|
|
||
| private String s; | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| PojoB that = (PojoB) o; | ||
| return s.equals(that.s); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(s); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "PojoB{" + | ||
| "s='" + s + '\'' + | ||
| '}'; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,4 +41,4 @@ void testRandomElementOf() { | |
| // Then | ||
| assertThat(element).isIn(elements); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if this is documented to be intended only for internal use, I do not remove public APIs without notice. Please put this back and mark it as deprecated (See how
DateUtilshas been deprecated in the same way).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted and marked deprecated