fix: Support Python 3.14 where ast._Unparser was moved#92
Open
MementoRC wants to merge 1 commit intoisidentical:mainfrom
Open
fix: Support Python 3.14 where ast._Unparser was moved#92MementoRC wants to merge 1 commit intoisidentical:mainfrom
MementoRC wants to merge 1 commit intoisidentical:mainfrom
Conversation
Python 3.14 moved ast._Unparser to _ast_unparse.Unparser (C extension module). Add conditional import to support both 3.10-3.13 (ast._Unparser) and 3.14+ (_ast_unparse.Unparser). All internal APIs (visit, traverse, fill, write, _indent, _source) remain identical in the new location. Fixes isidentical#91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Python 3.14 completely breaks
refactoron import:This also breaks downstream tools like teyit.
Root Cause
Python 3.14 moved
ast._Unparserto a C extension module_ast_unparse.Unparser. Theast.unparse()function now lazy-imports from there:Fix
Conditional import in
refactor/ast.py:All internal APIs (
visit,traverse,fill,write,_indent,_source) remain identical in the new location.Compatibility
ast._Unparser(unchanged behavior)_ast_unparse.UnparserFixes #91