Test/required check #6
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…into test/required-check
There was a problem hiding this comment.
Pull Request Overview
This PR modifies GitHub Actions workflows to add manual trigger capabilities and adjust build triggers. The changes appear to be focused on improving CI/CD flexibility and potentially addressing required check configurations.
- Added manual workflow dispatch trigger to the tag-build-release workflow with version and tag creation options
- Modified build workflow to remove push triggers and limit pull request triggers to master branch only
- Added minor whitespace changes to README
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/tag-build-release.yml | Added workflow_dispatch trigger with version input parameters and tag existence checking logic |
| .github/workflows/build.yml | Removed push triggers and limited pull request triggers to master branch |
| README.md | Added trailing whitespace lines |
| branches: [ master, main ] | ||
| pull_request: | ||
| branches: [ master, main ] | ||
| branches: [ master ] |
There was a problem hiding this comment.
Removing the 'main' branch from pull request triggers may prevent CI checks from running on PRs targeting the main branch if the repository uses 'main' as the default branch instead of 'master'.
| branches: [ master ] | |
| branches: [ main, master ] |
| - name: Create annotated tag | ||
| if: | | ||
| # Define conditions for better readability |
There was a problem hiding this comment.
[nitpick] The comment claims to define conditions for better readability, but the actual condition logic spans multiple lines below. Consider moving this comment closer to where the conditions are actually evaluated or removing it since the condition logic itself is self-explanatory.
| # Define conditions for better readability |
No description provided.