Test/required check #10

irsdl · 2025-08-01T21:46:13Z

Help & Readme Update

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…into test/required-check

SharePoint plugin has been updated Project has been restructured Helpers for Gadgets and Plugins have been created to make the application cleaner Tags have replaced GadgetTypes

Help & Readme Update

Copilot

Pull Request Overview

This PR introduces helper classes for gadget and plugin management and implements comprehensive refactoring of the YSoNet tool to improve maintainability and functionality. The changes replace hardcoded gadget discovery with centralized helper classes and implement better help system functionality.

Key changes include:

Introduction of GadgetHelper and PluginHelper classes for centralized gadget/plugin discovery and management
Comprehensive refactoring of Program.cs to use new helper classes and implement gadget/plugin-specific help
Updates to gadget labels and naming patterns for consistency
Code organization improvements and import statement reordering

Reviewed Changes

Copilot reviewed 80 out of 86 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
ysonet/Helpers/GadgetHelper.cs	New helper class for gadget discovery, validation, and instantiation
ysonet/Helpers/PluginHelper.cs	New helper class for plugin discovery, validation, and instantiation
ysonet/Program.cs	Major refactoring to use helper classes and implement specific help functionality
ysonet/Generators/Base/IGenerator.cs	Updated gadget labels/tags with clearer naming
ysonet/Generators/Base/GenericGenerator.cs	Implemented default Name() method using reflection
Various generator files	Removed redundant Name() overrides and updated label references
Various plugin files	Import statement reordering and minor cleanup

Copilot · 2025-08-01T21:47:35Z

ysonet/Program.cs


-
-                        if (!consumer_gadget.Labels().Contains(GadgetTypes.BridgeAndDerived))
+                        if (!consumer_gadget.Labels().Contains(GadgetTags.Bridged))


The label check has changed from GadgetTypes.BridgeAndDerived to GadgetTags.Bridged, but this may break existing functionality. Ensure that all gadgets that were previously marked as BridgeAndDerived are now properly marked as Bridged to maintain compatibility.

Copilot · 2025-08-01T21:47:36Z

ysonet/Generators/DataSetOldBehaviourGenerator.cs

+        string spoofedAssembly = "";
+
        public override OptionSet Options()
        {
            OptionSet options = new OptionSet()
            {
-                {"spoofedAssembly=", "The assembly name you want to use in the generated serialized object (example: 'mscorlib')", v => spoofedAssembly = v },
+                {"spoofedAssembly=", "The assembly name you want to use in the generated serialized object (example: 'mscorlib' or use 'default' for System.Data)", v => spoofedAssembly = v },


The default value for spoofedAssembly has changed from a specific assembly string to an empty string. This is a breaking change that could affect existing users who rely on the previous default behavior. Consider maintaining backward compatibility or clearly documenting this change.

Copilot · 2025-08-01T21:47:36Z

ysonet/Generators/DataSetOldBehaviourFromFileGenerator.cs

        }

-        string spoofedAssembly = "System.Data, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089";
+        string spoofedAssembly = "";


Same issue as in DataSetOldBehaviourGenerator - the default value for spoofedAssembly has changed from a specific assembly string to an empty string, which is a breaking change.

Suggested change

string spoofedAssembly = "";

string spoofedAssembly = "System.Data";

Copilot · 2025-08-01T21:47:36Z

ysonet/Generators/DataSetGenerator.cs

-            
-            DataSetMarshal payloadDataSetMarshal = new DataSetMarshal(binaryFormatterPayload);
+
+            DataSetBinaryMarshal payloadDataSetMarshal = new DataSetBinaryMarshal(binaryFormatterPayload);


The class name has changed from DataSetMarshal to DataSetBinaryMarshal. This is a breaking change that could affect code that directly references this class. Ensure all references are updated consistently throughout the codebase.

Copilot · 2025-08-01T21:47:37Z

ysonet/Generators/DataSetTypeSpoofGenerator.cs

-                
-            DataSetSpoofMarshal payloadDataSetMarshal = new DataSetSpoofMarshal(binaryFormatterPayload);
+
+            DataSetBinarySpoofMarshal payloadDataSetMarshal = new DataSetBinarySpoofMarshal(binaryFormatterPayload);


The class name has changed from DataSetSpoofMarshal to DataSetBinarySpoofMarshal. This is a breaking change that could affect code that directly references this class.

Copilot · 2025-08-01T21:47:37Z

ysonet/Generators/XamlAssemblyLoadFromFileGenerator.cs

+            if (variant_number == 2)
+            {
+                obj = new TextFormattingRunPropertiesMarshal(xmlResourceDict);
+            }
+            else
+            {
+                obj = TypeConfuseDelegateGenerator.GetXamlGadget(xmlResourceDict);


The logic for variant selection has been inverted. Previously variant 1 used TypeConfuseDelegateGenerator.GetXamlGadget() and variant 2 used TextFormattingRunPropertiesMarshal. Now it's the opposite. This could break existing functionality for users relying on specific variant behaviors.

Copilot · 2025-08-01T21:47:37Z

ysonet/Properties/AssemblyInfo.cs

 // General Information about an assembly is controlled through the following 
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
+[assembly: AssemblyMetadata("BuildTime", "$(DateTime.UtcNow)")]


The MSBuild property $(DateTime.UtcNow) will not be evaluated at compile time in this context. This will result in the literal string "$(DateTime.UtcNow)" being stored as metadata rather than the actual build time. Consider using a different approach for build time tracking.

Suggested change

[assembly: AssemblyMetadata("BuildTime", "$(DateTime.UtcNow)")]

[assembly: AssemblyMetadata("BuildTime", System.DateTime.UtcNow.ToString("o"))]

Copilot · 2025-08-01T21:47:37Z

ysonet/Generators/Base/GenericGenerator.cs

+        // This is used to return the name of the gadget
+        // It must be overridden especially in cases where a gadget inherits from another gadget


[nitpick] The default implementation uses reflection to derive the name from the class name. While this reduces code duplication, it creates a dependency on naming conventions. Consider documenting this convention clearly and ensuring it's consistently followed across all generators.

Suggested change

// This is used to return the name of the gadget

// It must be overridden especially in cases where a gadget inherits from another gadget

/// <summary>

/// Returns the name of the gadget by using the actual class name, removing "Generator" from the end if present.

///

/// <para>

/// <b>Naming convention:</b> All generator classes <b>must</b> have names ending with "Generator" for the default implementation to work correctly.

/// If a gadget inherits from another gadget or does not follow this convention, override this method to provide the correct name.

/// </para>

/// </summary>

irsdl and others added 9 commits July 26, 2025 23:38

test: trigger CI check

a5eae98

Update build.yml

83db8e5

Update tag-build-release.yml

9b4961f

Update .github/workflows/tag-build-release.yml

374dbeb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update build.yml

519c5b3

Merge branch 'test/required-check' of https://github.com/irsdl/ysonet …

7949044

…into test/required-check

Update README.md

a731f73

Refactor generators and sharepoint plugin update

929b22e

SharePoint plugin has been updated Project has been restructured Helpers for Gadgets and Plugins have been created to make the application cleaner Tags have replaced GadgetTypes

Help & Readme Update

f73eebc

Help & Readme Update

Copilot AI review requested due to automatic review settings August 1, 2025 21:46

Merge branch 'master' into test/required-check

aaa207a

Copilot AI reviewed Aug 1, 2025

View reviewed changes

irsdl added documentation Improvements or additions to documentation major labels Aug 1, 2025

irsdl merged commit 7858ff1 into master Aug 1, 2025
1 check passed

irsdl deleted the test/required-check branch August 1, 2025 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test/required check #10

Test/required check #10

Uh oh!

irsdl commented Aug 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		if (!consumer_gadget.Labels().Contains(GadgetTypes.BridgeAndDerived))
		if (!consumer_gadget.Labels().Contains(GadgetTags.Bridged))

	string spoofedAssembly = "";
	string spoofedAssembly = "System.Data";


		DataSetMarshal payloadDataSetMarshal = new DataSetMarshal(binaryFormatterPayload);

		DataSetBinaryMarshal payloadDataSetMarshal = new DataSetBinaryMarshal(binaryFormatterPayload);


		DataSetSpoofMarshal payloadDataSetMarshal = new DataSetSpoofMarshal(binaryFormatterPayload);

		DataSetBinarySpoofMarshal payloadDataSetMarshal = new DataSetBinarySpoofMarshal(binaryFormatterPayload);

	[assembly: AssemblyMetadata("BuildTime", "$(DateTime.UtcNow)")]
	[assembly: AssemblyMetadata("BuildTime", System.DateTime.UtcNow.ToString("o"))]

		// This is used to return the name of the gadget
		// It must be overridden especially in cases where a gadget inherits from another gadget

-        // This is used to return the name of the gadget
-        // It must be overridden especially in cases where a gadget inherits from another gadget
+        /// <summary>
+        /// Returns the name of the gadget by using the actual class name, removing "Generator" from the end if present.
+        ///
+        /// <para>
+        /// <b>Naming convention:</b> All generator classes <b>must</b> have names ending with "Generator" for the default implementation to work correctly.
+        /// If a gadget inherits from another gadget or does not follow this convention, override this method to provide the correct name.
+        /// </para>
+        /// </summary>

Test/required check #10

Test/required check #10

Uh oh!

Conversation

irsdl commented Aug 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants