Refactor: Enhance logger warning with variable storage for broader compatibility#68
Open
ever3001 wants to merge 1 commit intoinvl:masterfrom
Open
Refactor: Enhance logger warning with variable storage for broader compatibility#68ever3001 wants to merge 1 commit intoinvl:masterfrom
ever3001 wants to merge 1 commit intoinvl:masterfrom
Conversation
- Store formatted warning message in variable before logging - Ensure compatibility with structlog, loguru, and other logging libraries - Maintain support for both Python 2 and Python 3
jianghuifr
approved these changes
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues raised in #66 and #20 regarding logging compatibility and message formatting.
Changes
This change allows for easier integration with different logging libraries by separating the message formatting from the logging call. It also maintains backwards compatibility with existing setups.