Changes to make library compatible with Python3.#26
Open
baali wants to merge 1 commit intointernetarchive:masterfrom
Open
Changes to make library compatible with Python3.#26baali wants to merge 1 commit intointernetarchive:masterfrom
baali wants to merge 1 commit intointernetarchive:masterfrom
Conversation
Open
|
Ping @nibrahim - this would be useful to quite a few people - I've sent you a personal email, too. |
|
Would also love to see this merged. /cc @mekarpeles since he's an active maintainer of other internet archive projects. |
Author
|
I haven't worked again with this from quite some time, do let me know if you have noticed any bugs and I would be happy to update my PR with fixes... 🙏 |
|
@baali Noticed one around byte length calculations... Want me to put up a PR on your branch? |
Author
|
@piercefreeman That would be great 👍 |
|
@baali Put up a PR - let me know when you get a chance. |
|
ping. Is this or something like it going to be accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have been working on to make the library work with Py3. Changes include:
Existing tests are working fine with this PR but I think they need to be extended to make sure handling of bytes and str types are working in all possible scenarios. Do let me know your comments and reviews and I will fix and update the PR accordingly.