Skip to content

Fix Chrome shortcut does not work if bookmark shortcut is set#161

Merged
int128 merged 2 commits intomainfrom
fix-shortcut-key
Aug 20, 2022
Merged

Fix Chrome shortcut does not work if bookmark shortcut is set#161
int128 merged 2 commits intomainfrom
fix-shortcut-key

Conversation

@int128
Copy link
Copy Markdown
Owner

@int128 int128 commented Aug 20, 2022

Problem to solve

I noticed a Chrome shortcut key is not working when a shortcut key is set.

For example,

  • Set B as a shortcut of bookmark
  • Press Command + Shirt + B
  • It should not open the bookmark, but opens for now

How to solve

Don't handle a key if any modifier is set.

@github-actions
Copy link
Copy Markdown
Contributor

@int128 int128 changed the title Fix Chrome shortcut is not working Fix Chrome shortcut is not working if bookmark shortcut is set Aug 20, 2022
@github-actions
Copy link
Copy Markdown
Contributor

@int128 int128 changed the title Fix Chrome shortcut is not working if bookmark shortcut is set Fix Chrome shortcut does not work if bookmark shortcut is set Aug 20, 2022
@int128 int128 marked this pull request as ready for review August 20, 2022 00:33
@int128 int128 merged commit 544e2fc into main Aug 20, 2022
@int128 int128 deleted the fix-shortcut-key branch August 20, 2022 00:33
@github-actions
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant