CFINSPEC-155 Fix: command timeout ignored when used with sudo on ssh transport. #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vasu1105
changed the title
Vasu1105
force-pushed
the
vasundhara/fix-command-timeout-with-sudo
branch
from
6235600 to
60f080e
Compare
Vasu1105
changed the title
…h transport. Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Vasu1105
force-pushed
the
vasundhara/fix-command-timeout-with-sudo
branch
from
60f080e to
5a50db4
Compare
clintoncwolfe
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasu1105 vasundhara.jagdale@chef.io
Description
This fixes the command timeout is not working as expected when run with sudo. In the
execute_on_channelmethod inTrain::Transports::SSH::Connection class, the command is prepended with a timeout if thetimeoutoption is provided. We need to make sure whensudois used along with atimeoutoption should prepend with sudo.Related Issue
ZD30163
CFINSPEC-155
Types of changes
Checklist: