Allow the negate formating for cmp

[Taknok]

Description

The 'cmp' matcher when used with a negation as 'should_not' has a confusion formating when control fails:

This, because the 'format_actual' always pass 'false' to the 'format_expectation'. Thus the 'format_expectation' never reach the 'negate_str'.

When passing the negate value to the 'format_expectation' the output is more intuitive:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New content (non-breaking change)
• Breaking change (a content change which would break existing functionality or processes)
• other

Checklist:

• I have read the CONTRIBUTING document.

[netlify]

✅ Deploy Preview for chef-inspec canceled.

Name	Link
🔨 Latest commit	0dcf73a
🔍 Latest deploy log	https://app.netlify.com/sites/chef-inspec/deploys/65cd25315d43b300080f6bc2

[chef-expeditor]

Hello Taknok! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes
   a. If everything looks good, one of them will approve it, and your PR will be merged.
   b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
   c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

[Taknok]

I allow myself to send a message to up the topic as there was no comment since the beginning and 2 month passed.

[Taknok]

Should I drop this PR ? Is this an unwanted feature ?

[Vasu1105]

Thanks @Taknok and sorry for delay in reply. LGTM. Could you please rebase the branch and fix the lint failures and add unit test if possible around this?

[Taknok]

Hi,
I rebased my branch onto the main.
Which linting failure are you refering ? I do not see the buildkite report. The others do not show linting failures.
My modification does not impact the tests as the code was already there, the option was just not passed till the end.
On inspec/main:

On taknok/main:

[Vasu1105]

@Taknok This PR also missing DCO sign off please follow the Details https://github.com/chef/chef/blob/main/CONTRIBUTING.md#developer-certification-of-origin-dco and do the needful.

[Taknok]

Push force: The linting commit has also the DCO now.

[Vasu1105]

LGTM. Thanks @Taknok.