Skip to content

Conversation

@Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Oct 12, 2021

Signed-off-by: Nirbhay Kumar nkumar@progress.com

Description

It contains all the singular and plural resources of the above resource. This resource is tested manually and no terraform available.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@Nirbhay1997 Nirbhay1997 requested review from a team as code owners October 12, 2021 04:10
@Nirbhay1997 Nirbhay1997 marked this pull request as draft October 12, 2021 04:10
@Nirbhay1997 Nirbhay1997 added the wip WORK in Progress label Oct 12, 2021
@Nirbhay1997 Nirbhay1997 self-assigned this Oct 12, 2021
@soumyo13 soumyo13 linked an issue Oct 12, 2021 that may be closed by this pull request
Nirbhay Kumar added 2 commits October 14, 2021 08:35
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@soumyo13 soumyo13 marked this pull request as ready for review October 14, 2021 12:13
@soumyo13 soumyo13 added 2021_PQ4 and removed wip WORK in Progress labels Oct 14, 2021
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IanMadd and others added 3 commits November 19, 2021 12:07
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@soumyo13
Copy link
Contributor

@IanMadd Can you approve the PR if no changes are required?

Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit ae1d393 into main Nov 23, 2021
@soumyo13 soumyo13 deleted the Nirbhay/CloudWatch-destinantion branch November 23, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS::Logs::Destination

6 participants