Added support for Cloud front origin request policy #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
…nto Nirbhay/OriginRequestPolicy
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
…o Nirbhay/OriginRequestPolicy
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Contributor
|
CloudFront is one word so it shouldn't have an underscore between "cloud" and "front" in the resource name. |
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Contributor
Author
Done with the changes , Please verify. |
Contributor
Author
|
@IanMadd Can you please verify ?? |
IanMadd
approved these changes
Oct 27, 2021
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It contains the singular resource of the above resource. It does not have a plural resource.
Issues Resolved
This is a new resource. There are no issues to be fixed.
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lintpasses