Skip to content

Conversation

@kimjj93
Copy link
Collaborator

@kimjj93 kimjj93 commented Dec 24, 2025

Fixes #449

Added vignette for update_ard_fmt_fun and update_ard_stat_label under Articles

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Optional Reverse Dependency Checks:

Install checked with pak::pak("Genentech/checked") or pak::pak("checked")

# Check dev versions of `cardx`, `gtsummary`, and `tfrmt` which are in the `ddsjoberg` R Universe
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2L, repos = c('https://ddsjoberg.r-universe.dev', 'https://cloud.r-project.org'))"

# Check CRAN reverse dependencies but run tests skipped on CRAN
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

# Check CRAN reverse dependencies in a CRAN-like environment
Rscript -e "options(checked.check_envvars = c(NOT_CRAN = FALSE), checked.check_build_args = '--as-cran'); checked::check_rev_deps(path = '.', n = parallel::detectCores() - 2, repos = 'https://cloud.r-project.org')"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Unit Tests Summary

  1 files  203 suites   1m 1s ⏱️
203 tests 118 ✅  85 💤 0 ❌
454 runs  338 ✅ 116 💤 0 ❌

Results for commit 847c41c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_calculated_row 💚 $1.24$ $-1.20$ add_calculated_row_x_
apply_fmt_fun 💔 $0.04$ $+1.25$ apply_fmt_fun_works
ard_hierarchical 💔 $6.25$ $+1.06$ ard_hierarchical_works_without_by_variables
ard_stack 💚 $2.19$ $-1.18$ ard_stack_works
ard_stack_hierarchical 💔 $10.34$ $+2.01$ ard_stack_hierarchical_variables_
ard_summary 👶 $+0.04$ unnamed
ard_summary 💔 $0.43$ $+6.10$ ard_summary_works
shuffle_ard 💀 $0.04$ $-0.04$ unnamed
shuffle_ard 💚 $6.88$ $-6.84$ shuffle_trim_works

Results for commit 1df0e20

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update_ard_fmt_fn needs some love

2 participants