Conversation
|
@jpg0 I'd be interested in your review if you find some time. |
|
Somebody just recently asked for this, I can’t find where now. Nice! |
jpg0
left a comment
jpg0
left a comment
There was a problem hiding this comment.
Only high level thing that I would suggest is whether you want to support the flat structure with YAML, or just go straight to the structured one. If we do remove the flat one at some point, you don't want people having to migrate YAML when they could have gone straight to the V2 version.
Also don't forget docs!
Good point with the v1, does not make sense for people to use that. Docs are on the to-do. Thank you for the review. |
JW-CH
changed the title
| | -------------------------- | ------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | ImageRequestedNotification | Notifies when an image is requested. | `{"Name":"ImageRequestedNotification", "ClientIdentifier": "Frame_Kitchen", "DateTime":"2024-11-16T21:37:19.4933981+01:00", "RequestedImageId":"UUID"}` | | ||
|
|
||
| ### Multiple Immich Accounts |
There was a problem hiding this comment.
I think we need more detail on using this, maybe just a "see settings.example.x for more details?
| Only override settings you intend to change. | ||
| Defaults might change between versions, so keeping your config minimal helps future upgrades. | ||
| ::: | ||
|
|
There was a problem hiding this comment.
Should we have links to settings.example.json and yml here instead of the previous page?
3 participants
I hate that JSON has no support for comments - YAML does.
TODO: Add example & Update Docs