-
Notifications
You must be signed in to change notification settings - Fork 8
Restructuring of the Appearence of the JSON inside OCB #32
Description
Currently the Orion Context Broker (OCB) gets an entity of a robot with ALL of its topics. This is not strictly as intended for the FIWARE-Entities. They should be kept small...
Current OCB Content:
[
{
"id":"turtle1",
"type":"ROBOT",
"pose":{
"type":"turtlesim.Pose",
"value":{ ... },
"metadata":{ ... }
},
"cmd_vel":{
"type":"geometry_msgs.Twist",
"value":{ ... },
"metadata":{ ... }
}
}
]
Expected OCB Content:
[
{
"id":"turtle1/pose",
"type":"turtlesim.Pose",
"pose":{
"type":"turtlesim.Pose", // What is added here?
"value":{ ... },
"metadata":{ ... }
}
},
{
"id":"turtle1/cmd_vel",
"type":"geometry_msgs.Twist",
"cmd_vel":{
"type":"geometry_msgs.Twist", // What is added here?
"value":{ ... },
"metadata":{ ... }
}
}
]
It means, we need to do the following:
- Update The
contextBroker-Adapter (many changes) - Change the
topicHandler.py, so that we get different calls onpublish/subscribe - Restructuring of
rosConfigurator.pyandconfManager.py - Update
requestHandler.pyfor the corresponding Message-Output (WebServer) - (Possible Changes in FiwareObjectConverter)
- Documentation Updates!
FIROS will no longer support multiple instances on ONE OCB, where it only subscribes to a subset of messages (depending on the Context-Type-Attribute). This behaviour will be omitted. To only subscribe to some on the OCB, it needs to be specified inside robots.json and whitelist.json
In addition to that, the Issue #31 also needs to be completed.
For completeness: id will have the complete topic in it (maybe escaped with . @ptrdtznr ?)
and type will be the message type inside
The comment // What is added here? shows, that there is currently redundant information in one Entity. Maybe we can add some useful information there. Maybe it gets resolved during Implementation.
@DLuensch @ptrdtznr , are there more changes that need to be made?