Merged
Conversation
This includes rendering the reference files, a task that usually requires both the dedicate feature of the format as well as the `png` feature for the reference images.
They require different native dependencies in their build systems, one of the available on Ubuntu-20.04 (the latest Github build environment) while the other one is not.
197g
force-pushed
the
avif-and-default-tests
branch
from
e1d4bdc to
99a83e9
Compare
paolobarbolini
approved these changes
Feb 3, 2021
| - name: build | ||
| run: cargo build -v --no-default-features --features="avif" | ||
| # We don't test this yet, as it requires libdav1d which isn't in ubuntu 20.04 | ||
| # run: cargo build -v --no-default-features --features="avif-decoding" |
Contributor
There was a problem hiding this comment.
As described in the readme for dav1d-rs (https://github.com/rust-av/dav1d-rs#building) you may be able to work around this issue by setting the SYSTEM_DEPS_DAV1D_BUILD_INTERNAL=always environment variable to make it git clone dav1d from source, compile it and link it statically.
ninja and meson will have to be installed for this to work.
Member
Author
There was a problem hiding this comment.
Ah, seems interesting. I'll try after the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this splits avif-feature into encoder and decoder.
They require different native dependencies in their build systems, one
of the available on Ubuntu-20.04 (the latest Github build environment)
while the other one is not.
Unblocks: #1418