Skip to content

config.cpp: fix parsing invalid hex #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vaxerski merged 1 commit into from
Sep 1, 2024
Merged

config.cpp: fix parsing invalid hex #53

vaxerski merged 1 commit into from
Sep 1, 2024

Conversation

@MAKMED1337
Copy link
Contributor

@MAKMED1337 MAKMED1337 commented Aug 31, 2024

Instead of crashing on an invalid hex, return an error.

@MAKMED1337
config.cpp: fix parsing invalid hex
38d0680 
Instead of crashing on an invalid hex, return an error.
@MAKMED1337
Copy link
Contributor Author

MAKMED1337 commented Sep 1, 2024

There are also other usages of stoll in this function. Maybe it is better to add a stoll lambda function wrapper ?

vaxerski
vaxerski approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski
Copy link
Member

vaxerski commented Sep 1, 2024

There are also other usages of stoll in this function. Maybe it is better to add a stoll lambda function wrapper ?

could be done, but in a separate pr

@vaxerski vaxerski merged commit c12ab78 into hyprwm:main Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MAKMED1337 @vaxerski