Cannot change audio volume after presenting ImagePickerController

[chris-wickens]

After I have dismissed the ImagePickerController I find I can no longer change the volume of currently playing music using the volume buttons until I leave the app. (Running iOS 9)

[onmyway133]

@Rekubot Hi, when showing ImagePicker, we activate AudioSession and pause the playing music. After dismissing ImagePicker, you have to manually resume it, but changing volume still works

Do you mean to auto resume playing music after dismissing ImagePicker?

[Felizolinha]

I'm not sure if it's the same problem, but after dismissing the ImagePicker, pressing the audio button still takes pictures in the background.

[RNUK]

Same issue was occurring for me. After dismissing the ImagePicker, pressing the volume button continues to take photos.

Fixed by adding:
NotificationCenter.default.removeObserver(self, name: NSNotification.Name(rawValue: "AVSystemController_SystemVolumeDidChangeNotification"), object: nil)
to viewWillDisappear (line 156) of ImagePickerController.swift

[zenangst]

@Felizolinha are you sure that the image picker controller is properly deallocated at that point because it shouldn't be able to take pictures after you have dismissed it.

[zenangst]

@RNUK aha, I didn't see you comment there... nice find! Mind making a PR to fix this?

[RNUK]

@zenangst - Yeah, I'm kind of new to it all but I'll try.

[zenangst]

@RNUK we all have to start somewhere :)

[eliburke]

@RNUK You're fortunate this is an easy patch. 😄

• go to the repository home page and click the fork button in the top right to get your own personal copy.
• clone a local copy of YOUR forked ImagePicker. git checkout an appropriate branch (sometimes master, sometimes develop or another if that's what the repo maintainer wants)
• apply the fix
• commit the fix and push it back to github. if you make multiple commits, you will sometimes be asked to squash them into a single commit message. this can be super painful, but there are guides to be googled
• optionally, update your personal project to use your forked copy of the repository to test your fix (skip if you are confident)
• view the home page for your forked repository. typically it detects that you have pushed a change, so just click the green "Compare and Pull Request" button.
• verify the stuff, write a message for the PR, and then click "Create Pull Request"

[RNUK]

@eliburke thanks. Think I done it correctly...