WIP Applemail hack #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as multipart/mixed
Apple Mail messages of type multipart/alternative are only adding attachments to the text/html. This change allows to parse them as multipart/mixed, which, although not ideal, makes those attachments visible. Enable this option if text/plain is your prefered content.
as multipart/mixed
to multipart/mixed, use hypermail's set_save_alts to do the same in
a cleaner way.
The Apple Mail ua header value may change depening on what device
is used. Changed set_applemail_ua_value to a list so that new ones
can be added if needed. The default list values are "Apple iPhone"
(concatenanted to "Mail (" during the check (
…ative" This reverts commit 1678679.
hypermail's set_save_alts to deal with Apple Mail. Cleaner.
The Apple Mail UA string depends on the device used. set_apple_mail_ua
is now a list where you can add new device names. The default
values are Apple and iPhone. These are concatenated with "Mail (" when
doing a UA match.
have only two alternatives: text/plain and text/html, ignore the text/html one (and next step, make this happen only if text/plain is the prefered type). to ignore messages that only have two alternatives,
…var. default list of known Apple devices that can send mail
Check for valid values of save_alts Disable applemail_mimehack if save_alts is enabled or text/html is the prefered type.
Add a default not-in use value for old_save_alts to distinguish it from a valid save_alts value Rename parse_multipart_alternative_as_mixed to parse_multipart_alternative_force_save_alts to reflect what we're doing now.
hypermail discarded the first body.
The origlp and origbp variables used to store the parsed message before processing alternatives weren't being reset.
- improve detectionn and handling of multipart/alternative
and its exceptions for the applemail_hack
- when the value for applemail_ua_header was empty (""),
the header match strncasecmp returned true
- after choosing a mime alternative, the end process didn't reinitialize
two pointers to NULL, which could cause random issues
jkbzh
force-pushed
the
applemail_hack
branch
from
4239c55 to
6452713
Compare
iconv_close() wasn't always being called. iconv's buffer wasn't being reset when there was nothing to convert
middle of a string of iso-2022-jp encoded Japanese characters.
This fix makes it replace only the domain after the "@" char and only in an email address.
This fix makes it replace only the domain after the "@" char and only in an email address.
rfc3676 formatted messages can have both fixed and flowed lines. delsp wasn't always being removed fix folding of lines with quotes
the Subject and From headers.
optimization: The regex comparitions didn't stop at the first match but did all of them regardless.
A Content-Transfer-Encoding header with a missing value would be handled the same as an unknown encoding value: a message would be included in the body of the converted message stating the encoding was unknown as well as the unknown encoding value. However, if the value was missing, hypermail would use the value of an unitialized variable.
jkbzh
force-pushed
the
applemail_hack
branch
from
4656c4c to
b5eb9f1
Compare
seconds value was using the local date seconds value instead of 00.
jkbzh
added a commit
that referenced
this pull request
Dec 23, 2019
Merging to master for 2.4.0 release
jkbzh
added a commit
that referenced
this pull request
Dec 23, 2019
Merging to master for 2.4.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #52 #51