Skip to content

Fixing an include to fix the accidental extra space in the img src tag. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qwtel merged 1 commit into from
Dec 18, 2017
Merged

Fixing an include to fix the accidental extra space in the img src tag. #55

qwtel merged 1 commit into from
Dec 18, 2017

Conversation

@joseph-r-hamilton
Copy link

@joseph-r-hamilton joseph-r-hamilton commented Dec 17, 2017

Playing with html-proofer uncovered a bug.

@qwtel qwtel merged commit 476078b into hydecorp:master Dec 18, 2017
@qwtel
Copy link
Member

qwtel commented Dec 18, 2017 •
edited
Loading

Hi, thanks for this PR.

I wasn't aware of the {%- endif -%} syntax. Can you provide a link that explains it in detail?

Note that this should not be an issue in production builds (JEKYLL_ENV=production bundle exec jekyll build) though.

EDIT: wow, there's an extra space even in production builds. Thanks again for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joseph-r-hamilton @qwtel