feat: Bytes #76
Merged
feat: Bytes #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
is for #25 |
Collaborator
|
this looks great to me, really cool actually. would like to get another set of eyes on this before merging. |
jtriley2p
requested changes
Jan 29, 2023
Collaborator
jtriley2p
left a comment
jtriley2p
left a comment
There was a problem hiding this comment.
Overall, core logic looks good. Most comments are regarding comments, formatting, and minor changes.
However, the macro immediate vs stack arguments will require a few changes to the control flow, namely by changing <immediate_name> to dupN where N is the stack depth of the macro arguments (more details in the comments).
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing BytesLib in Huff