[PURR-89] [PURR-150] rework failure logic in the custom extension repository#1687
Merged
[PURR-89] [PURR-150] rework failure logic in the custom extension repository#1687
Conversation
Contributor
|
Yeah this needs some work, but the changes are in the same style it was originally in and if you say it works better then so be it. I would review the use multistep commands in shell_exec() and the use of echo "" inside of <?php rather than just using <?= to display variables inside of straight html. But both of these cases were in the original code so should not block this PR. |
nkissebe
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall, this component needs some major refactoring. It is way over architected. But these fixes should get it up and running for now.