Skip to content

[PURR-89] [PURR-150] rework failure logic in the custom extension repository#1687

Merged
dbenham merged 1 commit intodevfrom
purr-extension-manager-fixes
Nov 9, 2023
Merged

[PURR-89] [PURR-150] rework failure logic in the custom extension repository#1687
dbenham merged 1 commit intodevfrom
purr-extension-manager-fixes

Conversation

@dbenham
Copy link
Contributor

@dbenham dbenham commented Nov 6, 2023

  • This issue might have multiple related PRs in the system, PURR-89 is only the most recent.
  • Custom extension pulls via the admin were not working. The component would blankly report nothing during many scenarios and indicate nothing happening. There were multiple regular expression checks failing due to null values not being checked before doing regex checks.
  • I reworked some of the logic that was looking for errors in the php. The code was fragile, doing very specific regex checks for some errors. No custom logic was done with the error detection, other than an attempt to format errors differently than success messages.
  • I created a temp custom extension in gitlab, made various updates in that repo and tested this component to make sure it properly grabbed the new code.
  • No hotfix changes needed, this code should be part of 2.2.27

Overall, this component needs some major refactoring. It is way over architected. But these fixes should get it up and running for now.

@dbenham dbenham self-assigned this Nov 6, 2023
@dbenham dbenham requested a review from nkissebe as a code owner November 6, 2023 22:01
@dbenham dbenham changed the title [PURR-89] rework failure logic in the custom extension repository [PURR-89] [PURR-150] rework failure logic in the custom extension repository Nov 7, 2023
@nkissebe
Copy link
Contributor

nkissebe commented Nov 8, 2023

Yeah this needs some work, but the changes are in the same style it was originally in and if you say it works better then so be it. I would review the use multistep commands in shell_exec() and the use of echo "" inside of <?php rather than just using <?= to display variables inside of straight html. But both of these cases were in the original code so should not block this PR.

@dbenham dbenham merged commit 7c80b34 into dev Nov 9, 2023
@nkissebe nkissebe deleted the purr-extension-manager-fixes branch April 18, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments