Skip to content

"Ask a question" links do not work on tool pages#1686

Merged
dbenham merged 5 commits intodevfrom
fundsVarNotSet
Nov 14, 2023
Merged

"Ask a question" links do not work on tool pages#1686
dbenham merged 5 commits intodevfrom
fundsVarNotSet

Conversation

@jessewoo
Copy link
Contributor

Source JIRA card(s) and hubzero ticket(s)

Brief summary of the issue
"Ask a question" links do not work on tool pages, for example on the ATM Based Crevasse Detection & Extraction workflow. The error is a 500 error.

Brief summary of the fix

  • Using the debugger on production, the $funds variable wasn't set that was sent to the template page.
  • The error show !! Undefined variables: funds !!
  • Before the variable gets passed, $funds is set with an initial value of 0

Brief summary of your testing
Manual testing on ghub production site with SSH. Screenshot on the Jira ticket show the fix.

Do the change needs to be hotfixed to any production hubs before a normal core rollout
No

Double check someone is assigned to review the ticket
Yes - Nick and David

@jessewoo
Copy link
Contributor Author

jessewoo commented Nov 8, 2023

@dbenham - ready, removed tabs

Copy link
Contributor

@dbenham dbenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbenham dbenham merged commit d9f5a72 into dev Nov 14, 2023
@nkissebe nkissebe deleted the fundsVarNotSet branch April 18, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments