Skip to content

[UCCOMMHUB-11] fix rendering of menu on tool license page#1670

Merged
nkissebe merged 2 commits intodevfrom
uccommhub11
Oct 6, 2023
Merged

[UCCOMMHUB-11] fix rendering of menu on tool license page#1670
nkissebe merged 2 commits intodevfrom
uccommhub11

Conversation

@JackS9
Copy link
Contributor

@JackS9 JackS9 commented Sep 5, 2023

Tool license page is not rendered properly

  • JIRA card: https://sdx-sdsc.atlassian.net/browse/UCCOMMHUB-11
  • Support ticket: https://uccommunityhub.hubzero.org/support/ticket/46
  • Brief summary of the issue: The dropdown menus on the tool license page of the tool create pipeline was rendering full width of page.
  • Brief summary of the fix/changed code: Added max-width (of 25%) to the .shifted entry in the pipeline CSS, which is used on those menu select tags.
  • Brief summary of your testing: Could not be tested directly on uccommunithhub.org, but Mona could mimic the proposed change within the browser inspector.
  • Hotfixed needed? no

Copy link
Contributor

@nkissebe nkissebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to Ilya, I have no objections

Copy link
Contributor

@dbenham dbenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're a bit curious about why/where this happened. @ilya is interested in finding a root cause.

@dbenham dbenham requested a review from ishunko September 6, 2023 18:23
@dbenham dbenham marked this pull request as draft September 6, 2023 19:46
@nkissebe nkissebe force-pushed the dev branch 3 times, most recently from e42b6ed to 8d38cdf Compare October 6, 2023 20:26
@nkissebe nkissebe marked this pull request as ready for review October 6, 2023 20:29
@nkissebe nkissebe merged commit eca3fc7 into dev Oct 6, 2023
@nkissebe nkissebe deleted the uccommhub11 branch April 18, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments