Broken Previous Button for Tool Description#1660
Merged
Conversation
nkissebe
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference
Summary of the Issue
Editing the Tools description, on the "Finalize" tab, the "< previous" button is broken and doesn't match the style. It should go to "Tags" tab, but it currently goes to the pipeline page. It is not just happening on Nanohub, but on all CMS.
Summary of the Development
The controller should have been pointed to the 'resources' controller upon submission, but it was defaulting to the preview.php controller of 'pipeline'. The 'pipeline' controller doesn't have a way to respond to the "< previous" button.
Testing
The fix can be tested on https://dev.nanohub.org/tools/pipeline.