Admin page for Groups throws error#1651
Merged
nkissebe merged 2 commits intohubzero:devfrom Oct 5, 2023
Merged
Conversation
Variable $customFieldForm was misspelled as $customFieldForms and throwing error in specific case when a group CN error was encountered.
nkissebe
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error was encountered while generating test data. There is no ticket or Jira card.
A clear misspelling of a variable name (
$customFieldFormsinstead of$customFieldForm) was resulting in an error being thrown, "Undefined variable: customFieldForms". This error occurred on creating a group on the admin interface, in the specific case when the Group's Alias was left blank.After the variable name was corrected, it became clear that the UI's error message about the missing Alias could be improved. The message originally referred to a missing "Group ID". The message has been amended to refer to the Alias.
Testing
Testing this small change was performed on a VirtualBox VM on the developer's workstation. Specificially, the admin page for creating groups was loaded and a new Group created with the Alias left blank. With the fix in place, the appropriate error message was seen, prompting the user for an Alias; before the fix, the page threw an unrecoverable error.