Issue: Series Resource incorrectly displaying 'workshop' button#1637
Merged
Issue: Series Resource incorrectly displaying 'workshop' button#1637
Conversation
dbenham
reviewed
Jun 30, 2023
Contributor
dbenham
left a comment
dbenham
left a comment
There was a problem hiding this comment.
Break statements generally aren't required unless there is a chance more than one of the cases evaluates to true. Are you sure this fixed the problem?
Contributor
|
Code will flow from one case to the next without break. This fix looks correct, not sure how it hadn't been noticed until now. |
nkissebe
approved these changes
Jun 30, 2023
Contributor
Author
|
@dbenham - you can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources
Issue Summary
On a resource page for a series, the workshop button is showing up.
Fix Summary
In the creation of the primary buttons, there was a switch statement that was written improperly. Each case didn't have a break. Fix was adding a break to each case.
Testing
Rollout
Review