[fix] Tags for versions where being deleted#1555
Merged
nkissebe merged 1 commit intohubzero:devfrom May 25, 2022
Merged
Conversation
Legacy code removed from when tags were associated with publications and not versions. This code was inadvertently deleting tags for versions with ids matching the removed publication id.
Contributor
Author
|
Wait, this pull request might be incomplete. Checking code now to make sure version tags are being deleted. Will add additional commits soon if needed. |
Contributor
Author
|
Okay, looks like version tags are deleted appropriately. I think this is the only code change needed to fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy code removed from when tags were associated with publications
and not versions. This code was inadvertently deleting tags for
versions with ids matching the removed publication id.