Merged
Conversation
The com_publications admin used a relative require that failed to load com_plugins if com_publications was copied to app for local changes but com_plugins was not. This change uses the Component::path method to get the correct location of com_plugins
The helpers.php file for mod_articles_category was out of date compared to the current usage of core library classes. In some cases it was applying unset filter attributes in a way that ensured no content entries would match the query. In other cases it was assuming attributes of the returned items describing the category it belonged to were present but they no longer are. The instigation of this fix were a couple of errors related to the renaming of the old published column to state and the use of the Query class with a mismatched set of parameters to the whereRaw method. This commit should solve all of those issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper.php file for mod_articles_category was out of date
compared to the current usage of core library classes. In some
cases it was applying unset filter attributes in a way that
ensured no content entries would match the query.
In other cases it was assuming attributes of the returned items
describing the category it belonged to were present but they no
longer are. The instigation of this fix were a couple of errors
related to the renaming of the old published column to state
and the use of the Query class with a mismatched set of
parameters to the whereRaw method. This commit should solve all
of those issues.