[pull] master from violentmonkey:master

.browserslistrc

@@ -1,2 +1,2 @@
-Chrome >= 55
-Firefox >= 53
+Chrome >= 61
+Firefox >= 57

.editorconfig

@@ -7,6 +7,4 @@ end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
-
-[*.md]
-trim_trailing_whitespace = false
+quote_type = single

.eslintignore

@@ -1,4 +1,6 @@
 **/*.js
 !src/**
 !test/**
+!scripts/*
+!gulpfile.js
 src/public/**

.eslintrc.js

@@ -1,30 +1,34 @@
+const { readGlobalsFile, restrictedSyntax } = require('./scripts/webpack-util');
+const ovr = makeOverrides();
+
 module.exports = {
   root: true,
   extends: [
-    require.resolve('@gera2ld/plaid/eslint'),
-    require.resolve('@gera2ld/plaid-vue/eslint/vue'),
+    'eslint:recommended',
+    'plugin:vue/vue3-essential',
+    'prettier',
   ],
+  env: {
+    browser: true,
+    node: true,
+    es2021: true,
+  },
   parserOptions: {
-    ecmaFeatures: {
-      legacyDecorators: true,
-    },
+    parser: '@babel/eslint-parser',
+    ecmaVersion: 'latest',
+    sourceType: 'module',
   },
-  overrides: [{
-    // `browser` is a local variable since we remove the global `chrome` and `browser` in injected*
-    // to prevent exposing them to userscripts with `@inject-into content`
-    files: ['*'],
-    excludedFiles: [
-      'src/injected/**/*.js',
-      'src/common/*.js',
-    ],
-    globals: {
-      browser: false,
-    },
-  }],
+  plugins: ['jest'],
   rules: {
-    'import/extensions': ['error', 'ignorePackages', {
-      js: 'never',
-      vue: 'never',
+    'prettier/prettier': 'off',
+    'no-constant-condition': 'off',
+    'no-shadow': 2,
+    'no-unused-expressions': 2,
+    'no-use-before-define': ['error', {
+      'functions': false,
+      'classes': true,
+      'variables': false, // allowing for upper scopes
+      'allowNamedExports': true,
     }],
     // copied from airbnb-base, replaced 4 with 8
     'object-curly-newline': ['error', {
@@ -33,5 +37,153 @@ module.exports = {
       ImportDeclaration: { minProperties: 8, multiline: true, consistent: true },
       ExportDeclaration: { minProperties: 8, multiline: true, consistent: true },
     }],
+    'semi': ['error'],
   },
+  overrides: [{
+    // `browser` is a local variable since we remove the global `chrome` and `browser` in injected*
+    // to prevent exposing them to userscripts with `@inject-into content`
+    files: ['*'],
+    excludedFiles: [...ovr.FILES_INJECTED, ...ovr.FILES_SHARED],
+    globals: {
+      browser: false,
+      ...ovr.GLOBALS_COMMON,
+    },
+  }, {
+    files: ovr.FILES_SHARED,
+    globals: ovr.GLOBALS_COMMON,
+  }, {
+    files: ovr.FILES_WEB,
+    globals: ovr.GLOBALS_WEB,
+  }, {
+    files: ovr.FILES_CONTENT,
+    globals: ovr.GLOBALS_CONTENT,
+  }, {
+    files: ovr.FILES_INJECTED,
+    excludedFiles: [...ovr.FILES_CONTENT, ...ovr.FILES_WEB],
+    // intersection of globals in CONTENT and WEB
+    globals: Object.keys(ovr.GLOBALS_CONTENT).reduce((res, key) => (
+      Object.assign(res, key in ovr.GLOBALS_WEB && { [key]: false })
+    ), {}),
+  }, {
+    files: [...ovr.FILES_INJECTED, ...ovr.FILES_SHARED],
+    rules: ovr.INJECTED_RULES,
+  }, {
+    files: ovr.FILES_WEB,
+    rules: {
+      ...ovr.INJECTED_RULES,
+      'no-restricted-syntax': [
+        ...ovr.INJECTED_RULES['no-restricted-syntax'],
+        {
+          selector: '[regex], NewExpression[callee.name="RegExp"]',
+          message: 'RegExp internally depends on a *ton* of stuff that may be spoofed or broken',
+          // https://262.ecma-international.org/12.0/#sec-regexpexec
+        },
+      ],
+    },
+  }, {
+    // build scripts
+    files: [
+      '*.js',
+      'scripts/*.js',
+      'scripts/*.mjs',
+    ],
+    env: { node: true },
+    rules: {
+      'global-require': 0,
+      'import/newline-after-import': 0,
+      'import/no-extraneous-dependencies': 0, // spits errors in github action
+      'import/extensions': 0,
+    }
+  }, {
+    files: ['*.vue'],
+    rules: {
+      'vue/multi-word-component-names': 0,
+    },
+  }, {
+    files: ['test/**'],
+    env: {
+      'jest/globals': true,
+    },
+  }],
 };
+
+function makeOverrides() {
+  /* Note that `injected` uses several more `common` files indirectly, but we check just these
+   * two automatically because they are trivial by design and must always pass the check */
+  const GLOBALS_SHARED = getGlobals('*');
+  const GLOBALS_INJECTED = {
+    ...getGlobals('injected'),
+    PAGE_MODE_HANDSHAKE: false,
+    VAULT_ID: false,
+  };
+  function getGlobals(path) {
+    const res = {};
+    const { ast } = readGlobalsFile(path, { ast: true });
+    ast.program.body.forEach(body => {
+      const { declarations } = body.declaration || body;
+      if (!declarations) return;
+      declarations.forEach(function processId({
+        id: {
+          left,
+          properties,
+          name = left && left.name,
+        },
+      }) {
+        if (name) {
+          // const NAME = whatever
+          // We consider `let` immutable too to avoid unintentional reassignment
+          res[name] = false;
+        } else if (properties) {
+          // const { NAME1, prototype: { NAME2: ALIAS2 } } = whatever
+          properties.forEach(({ value }) => processId({ id: value }));
+        }
+      });
+    });
+    return res;
+  }
+
+  return {
+    FILES_CONTENT: [
+      'src/injected/index.js',
+      'src/injected/content/**/*.js',
+    ],
+    FILES_INJECTED: [
+      'src/injected/**/*.js',
+    ],
+    FILES_SHARED: [
+      'src/common/browser.js',
+      'src/common/consts.js',
+      'src/common/safe-globals-shared.js',
+    ],
+    FILES_WEB: [
+      'src/injected/web/**/*.js',
+    ],
+    GLOBALS_INJECTED,
+    GLOBALS_SHARED,
+    GLOBALS_COMMON: {
+      ...GLOBALS_SHARED,
+      ...getGlobals('common'),
+      re: false, // transform-modern-regexp with useRe option
+    },
+    GLOBALS_CONTENT: {
+      INIT_FUNC_NAME: false,
+      ...GLOBALS_SHARED,
+      ...getGlobals('injected/content'),
+      ...GLOBALS_INJECTED,
+    },
+    GLOBALS_WEB: {
+      ...GLOBALS_SHARED,
+      ...getGlobals('injected/web'),
+      ...GLOBALS_INJECTED,
+      IS_FIREFOX: false, // passed as a parameter to VMInitInjection in webpack.conf.js
+    },
+    INJECTED_RULES: {
+      'no-restricted-imports': [
+        'error', {
+          patterns: ['*/common', '*/common/*'],
+        }
+      ],
+      'no-restricted-syntax': ['error', ...restrictedSyntax],
+    },
+  };
+}

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,28 @@
+---
+name: Bug report
+about: For bugs that also exist in beta
+title: "[BUG] "
+labels: bug
+assignees: ''
+
+---
+
+<!-- Please search the existing issues first as the problem may be already reported.
+     Please verify the bug is not fixed in the latest beta:
+     https://github.com/violentmonkey/violentmonkey/releases -->
+
+### Sequence of actions: <!-- e.g. install userscript, open example.com, click page -->
+1.
+2.
+3.
+
+### Problem: <!-- e.g. error in devtools console -->
+
+### Expected result:  <!-- e.g. "ok" in console or some button appears -->
+
+#### Devtools console contents:
+
+#### Environment:
+- OS: Windows
+- Browser: Chrome 123 <!-- specify the real version -->
+- Violentmonkey Version:

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: "[Feature] "
+labels: enhancement
+assignees: ''
+
+---
+
+**Motivation**
+<!-- Is your feature request related to a problem? Please describe what the problem is. -->
+
+**Proposed Solution**
+<!-- A clear and concise description of what you want to happen. -->
+
+**Use Cases**
+<!-- If applicable, please describe how you would use this feature. -->

.github/workflows/amo-download.yml

@@ -0,0 +1,50 @@
+name: Download AMO signed unlisted package
+
+on:
+  workflow_dispatch:
+    inputs:
+      version:
+        required: true
+  repository_dispatch:
+    types:
+      - amo_download
+
+jobs:
+  amo-download:
+    if: ${{ github.event.client_payload.version || github.event.inputs.version }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '20'
+
+      - name: Prepare
+        run: yarn && node scripts/action-helper.js
+        env:
+          ACTION_BUILD_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+          DISCORD_WEBHOOK_RELEASE: ${{ secrets.DISCORD_WEBHOOK_RELEASE }}
+          VERSION: ${{ github.event.client_payload.version || github.event.inputs.version }}
+
+      - name: Download signed file and upload to GitHub release
+        run: |
+          mkdir -p $TEMP_DIR/updates
+          DEBUG=amo-upload BETA=1 node scripts/amo-upload.mjs
+        env:
+          AMO_KEY: ${{ secrets.AMO_KEY }}
+          AMO_SECRET: ${{ secrets.AMO_SECRET }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Update updates.json
+        uses: JamesIves/github-pages-deploy-action@4.1.0
+        with:
+          branch: updates
+          folder: ${{ env.TEMP_DIR }}/updates
+          commit-message: Update to ${{ env.VERSION }} 🚀
+
+      - name: Upload assets
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          node -e 'import("./scripts/release-helper.mjs").then(({ uploadAssets }) => uploadAssets())';