Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My opinion about #166. Note that the only people to have been getting cythonized param would be those installing from pip while also having cython and a functioning c compiler.
python setup.py developis silently broken for param #161 (makes it redundant).If merged, I would open an issue about considering cythonizing once:
Meanwhile, it might be useful to cythonize param as part of testing (e.g. can be useful to catch certain classes of error/bad practice). We could maybe add a command/argument to setup.py to optionally cythonize param.