-
-
Notifications
You must be signed in to change notification settings - Fork 81
API removals #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API removals #1085
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 88.06% 89.16% +1.10%
==========================================
Files 9 9
Lines 4884 4679 -205
==========================================
- Hits 4301 4172 -129
+ Misses 583 507 -76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This shouldn't be controversial, merging. |
|
Sounds good, thanks! Please monitor the CI for any of our downstream projects that might be affected by this change. Hopefully they've already been updated based on the warnings, but you never know! |
|
Will do (I consider it unlikely, and hoxbot is pretty good at taking care of deprecation warnings in our test suites, but who knows). |
|
@maximlt A little confused by this PR, you removed the |
|
My bad, I had incorrectly recalled what the consensus decision was and had assumed we were removing |
|
That's still possible if you want to argue for it, with another deprecation round! This one isn't lost though, it has helped us improve the signature of all parameters. Personally, I no longer get confused with passing |
|
I think the ship has sailed tbh. We're definitely in a better place now and I don't hate it, though personally I'd never use it. |
This PR removes the API that has been emitting a deprecation warning at the
ParamFutureWarninglevel (so visible in a notebook, in a Panel app, etc.) since 2.2.0 (released in December 2024, ~10 months ago), and already deprecated either in 2.0.0 or even before.2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0List._class: use insteaditem_type2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0Number.set_hook: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.produce_value: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.as_unicode: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.is_ordered_dict: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.hashable: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.named_objs: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.normalize_path: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.__init__module /param.abbreviate_paths: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.parameterizedmodule /param.parameterized.all_equal: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.parameterizedmodule /param.parameterized.add_metaclass: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.parameterizedmodule /param.parameterized.batch_watch: use insteadbatch_call_watchers2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.parameterizedmodule /param.parameterized.recursive_repr: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0param.parameterizedmodule /param.parameterized.overridable_property: no replacement2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.set_default: use insteadfor k,v in p.param.objects().items(): print(f"{p.__class__.name}.{k}={repr(v.default)}2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param._add_parameter: use instead.param.add_parameter2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.params: use instead.param.values()or.param['param']2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.set_param: use instead.param.update2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.get_param_values: use instead.param.values().items()(or.param.values()for the common case ofdict(....param.get_param_values()))2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.params_depended_on: use instead.param.method_dependencies2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.defaults: use instead{k:v.default for k,v in p.param.objects().items()}2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.print_param_defaults: use insteadfor k,v in p.param.objects().items(): print(f"{p.__class__.name}.{k}={repr(v.default)}")2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.print_param_values: use insteadfor k,v in p.param.objects().items(): print(f"{p.__class__.name}.{k}={repr(v.default)}")2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.message: use instead.param.log(param.MESSAGE, ...)2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.verbose: use instead.param.log(param.VERBOSE, ...)2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.0.0, soft-deprecated since1.12.0.paramnamespace /.param.debug: use instead.param.log(param.DEBUG, ...)2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.1.0,ParamPendingDeprecationWarningsince2.0.0defaultis deprecated2.3.0ParamFutureWarningsince2.2.0,ParamDeprecationWarningsince2.1.0,ParamPendingDeprecationWarningsince2.0.0Selectorparameters that acceptobjectsas first positional argument, andClassSelectorparameters that acceptclass_as first positional argument, passing any argument by position is deprecated.