-
-
Notifications
You must be signed in to change notification settings - Fork 81
Fix error message of ReactiveESMMetaClass #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that error messages for parameters owned by classes using custom metaclasses derived from ParameterizedMetaclass correctly display the class name rather than the metaclass name.
- Updated
_validate_error_prefixto recognize subclasses ofParameterizedMetaclass. - Added a new test to verify that custom metaclass names no longer appear in error messages.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/teststringparam.py | Added test_reject_none_custom_metaclass to confirm the fix. |
| param/_utils.py | Changed prefix logic to use issubclass for detecting metaclass subclasses. |
|
@MarcSkovMadsen pre-commit is not happy. |
jbednar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense. Thanks for figuring this out and submitting the PR!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 87.48% 87.48%
=======================================
Files 9 9
Lines 4961 4961
=======================================
Hits 4340 4340
Misses 621 621 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closing #1063