perf: Only update Parameter signatures when needed #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
force-pushed
the
reduce_signature
branch
from
4379ee0 to
31affcd
Compare
hoxbro
commented
Feb 27, 2025
|
|
||
| [tool.coverage.report] | ||
| omit = ["param/version.py"] | ||
| omit = ["param/version.py", "tests/testimports.py"] |
Member
Author
There was a problem hiding this comment.
This belongs to the other PR, but I don't think moving it over to it is important.
hoxbro
force-pushed
the
reduce_signature
branch
from
163fb6d to
23f1177
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
- Coverage 87.46% 87.45% -0.02%
==========================================
Files 9 9
Lines 4948 4952 +4
==========================================
+ Hits 4328 4331 +3
- Misses 620 621 +1 ☔ View full report in Codecov by Sentry. |
hoxbro
commented
Feb 27, 2025
hoxbro
changed the title
hoxbro
commented
Feb 27, 2025
maximlt
reviewed
Feb 27, 2025
Member
maximlt
left a comment
maximlt
left a comment
There was a problem hiding this comment.
Thanks for splitting the original PR!
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
hoxbro
commented
Feb 27, 2025
maximlt
changed the title
maximlt
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. In IPython environment or in docs build (by setting a system environment variable)